Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MLJBase.jl dep to last version #1037

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Updating MLJBase.jl dep to last version #1037

merged 1 commit into from
Aug 24, 2023

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Aug 24, 2023

No description provided.

@pebeto pebeto requested a review from ablaom August 24, 2023 06:07
@pebeto pebeto self-assigned this Aug 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1037 (72625fa) into dev (585a120) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1037   +/-   ##
=======================================
  Coverage   60.97%   60.97%           
=======================================
  Files           2        2           
  Lines          41       41           
=======================================
  Hits           25       25           
  Misses         16       16           

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, MLJFlow will not work unless MLJBase.jl is the recent version or better.

Nice catch, thanks @pebeto

@ablaom ablaom merged commit 13b2233 into dev Aug 24, 2023
3 checks passed
@ablaom ablaom mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants